Add a dummy workflow to succeed DCO check on merge queues - #366
Merged
leandro-lucarella-frequenz merged 4 commits intoApr 28, 2023
Merged
Conversation
leandro-lucarella-frequenz
added
part:tooling
Contributor
Author
|
I re-enabled the DCO requirement for merging. I set to merge when ready, lets see if it works! |
leandro-lucarella-frequenz
enabled auto-merge
April 27, 2023 07:54
See frequenz-floss#363 for more details. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
leandro-lucarella-frequenz
force-pushed
the
dummy-dco-merge
branch
from
April 27, 2023 08:32
520a542 to
41d1514
Compare
sahas-subramanian-frequenz
previously approved these changes
Apr 27, 2023
leandro-lucarella-frequenz
added this pull request to the merge queue
Apr 27, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Apr 27, 2023
leandro-lucarella-frequenz
added this pull request to the merge queue
Apr 27, 2023
The `generate-docs-pr` should also run for `merge_group` (and also `workflow_dispatch`, why not?), so we change the `if` condition to only exclude `push`es. We also rename the job to `test-generate-docs` to make it more generic. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Contributor
Author
|
Added a commit to make |
sahas-subramanian-frequenz
previously approved these changes
Apr 27, 2023
matthias-wende-frequenz
previously approved these changes
Apr 27, 2023
leandro-lucarella-frequenz
removed this pull request from the merge queue due to a manual request
Apr 27, 2023
leandro-lucarella-frequenz
enabled auto-merge
April 27, 2023 12:42
leandro-lucarella-frequenz
disabled auto-merge
April 27, 2023 12:42
leandro-lucarella-frequenz
enabled auto-merge
April 27, 2023 12:43
leandro-lucarella-frequenz
added this pull request to the merge queue
Apr 27, 2023
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
leandro-lucarella-frequenz
dismissed stale reviews from matthias-wende-frequenz and sahas-subramanian-frequenz
via
April 27, 2023 13:24
3582178
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
sahas-subramanian-frequenz
approved these changes
Apr 27, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Apr 27, 2023
leandro-lucarella-frequenz
added this pull request to the merge queue
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #363 for
more details.